feat: make workflow computable without instantiating dependents #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metacosm
force-pushed
the
further-workflow
branch
2 times, most recently
from
91d8d44 to
fac0211
Compare
|
Replaces #1641. |
|
Do we still need the |
Unless you have a way to remove it, yes, we still need it as it's still used in the code. |
csviri
reviewed
Dec 6, 2022
...io/javaoperatorsdk/operator/api/config/dependent/DependentResourceConfigurationResolver.java
Show resolved
Hide resolved
...hema/src/main/java/io/javaoperatorsdk/operator/sample/dependent/SchemaDependentResource.java
Show resolved
Hide resolved
|
Just added 2 remarks, 1 is just conceptuial idea, otherwise makes sense, I like the changes :) |
csviri
approved these changes
Dec 6, 2022
metacosm
force-pushed
the
further-workflow
branch
from
a24ae1d to
a6ffa83
Compare
csviri
reviewed
Dec 9, 2022
...n/java/io/javaoperatorsdk/operator/processing/dependent/workflow/DefaultManagedWorkflow.java
Show resolved
Hide resolved
This allows for workflows to be computed at build time, only to be resolved (i.e. associating workflow nodes to actual dependent resources) when needed. In the process, the configuration mechanism of managed dependent resource has been improved to make it possible to resolve the configuration solely from the dependent resource class instead of previously requiring the dependent to be instantiated. This is now done viw the DependentResourceConfigurationResolver class.
metacosm
force-pushed
the
further-workflow
branch
from
a6ffa83 to
0e1bd3f
Compare
|
Kudos, SonarCloud Quality Gate passed! |
metacosm
added a commit
to quarkiverse/quarkus-operator-sdk
that referenced
this pull request
Dec 9, 2022
metacosm
added a commit
to quarkiverse/quarkus-operator-sdk
that referenced
this pull request
Dec 11, 2022
metacosm
added a commit
that referenced
this pull request
Dec 14, 2022
…es (#1647) This allows for workflows to be computed at build time, only to be resolved (i.e. associating workflow nodes to actual dependent resources) when needed. In the process, the configuration mechanism of managed dependent resource has been improved to make it possible to resolve the configuration solely from the dependent resource class instead of previously requiring the dependent to be instantiated. This is now done viw the DependentResourceConfigurationResolver class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1648